Skip to content

Podman6: Remove cgroupsv1 #27271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Podman6: Remove cgroupsv1 #27271

wants to merge 23 commits into from

Conversation

@lsm5
Copy link
Member

@lsm5 lsm5 commented Oct 10, 2025

Does this PR introduce a user-facing change?

Cgroups v1 support has been removed.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note labels Oct 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
@lsm5 lsm5 added 6.0 Breaking changes for Podman 6.0 and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. machine release-note labels Oct 10, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Oct 10, 2025

I'd say keep this in draft until #27270 merges, then rebase ontop of that. Currently, with all the octal format changes, it's practically impossible to give the real change a review.

@lsm5
Copy link
Member Author

lsm5 commented Oct 10, 2025

I'd say keep this in draft until #27270 merges, then rebase ontop of that. Currently, with all the octal format changes, it's practically impossible to give the real change a review.

Sure, nothing's happening on this one until we branch v5.7. #27270 ideally should go into v5.7.

@lsm5
Copy link
Member Author

lsm5 commented Oct 10, 2025

@TomSweeneyRedHat ah i see what you mean about the reviews part. sgtm.

@packit-as-a-service
Copy link

packit-as-a-service bot commented Oct 17, 2025

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@lsm5 lsm5 force-pushed the podman6-no-cgv1 branch 7 times, most recently from 04bc7f3 to f92d40c Compare October 23, 2025 15:35
@lsm5 lsm5 mentioned this pull request Oct 23, 2025
Closed
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Nov 5, 2025
@lsm5 lsm5 force-pushed the podman6-no-cgv1 branch 3 times, most recently from 95b242c to f571849 Compare November 5, 2025 16:05
@lsm5
Copy link
Member Author

lsm5 commented Nov 7, 2025

I think once the unrelated deprecation issue is resolved, and including a build failure fix that's in my HEAD commit, I'd probably be ok to retry with re-reverting with the large cgroupsv1 removal here. I could leave it as-is for now OR have this merged without the HEAD (vendoring) commit. I'm cool either way.

lsm5 added 3 commits November 10, 2025 13:20
@lsm5
cmd/podman.persistentRunE(): Fatal linux check if no Cgroups v2
de26530 
Will log and proceed on non-linux env.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
cmd/podman/containers/unpause: Remove cgroupv1 check
8846d1e 
This didn't error check for mounted cgroups, only errored for rootless
cgroupsv1 containers. Safe to remove.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
libpod/container_internal*.go: Remove Cgroups v1
49943da 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
Copy link
Member Author

lsm5 commented Nov 10, 2025

I would like to remove the HEAD commit from here that does some vendoring to simplify cgroups.AvailableControllers and leave a FIXME note instead. That would move this forward at least.

lsm5 added 20 commits November 10, 2025 13:38
@lsm5
libpod/info_linux.go: Remove Cgroups v1
5d39107 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
libpod/runtime_linux.go: Remove Cgroups v1
2ba50f4 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
libpod/runtime_pod_linux.go: Remove Cgroups v1
a1b2b86 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
pkg/domain/infra/runtime_libpod.go: Remove Cgroups v1
afcac3b 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
pkg/specgen/generate/validate_linux.go: Remove Cgroups v1
30c6df7 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
libpod/runtime_ctr.go: Remove Cgroups v1
b6d2edb 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
libpod/runtime.go: Remove Cgroups v1
81c3064 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
libpod/util_linux.go: Remove Cgroups v1
3a04ccc 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
libpod/pod_api.go: Remove Cgroups v1
70dc291 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
pkg/specgen/namespaces.go: Remove Cgroups v1
c6ecc1b 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
pkg/domain/infra/abi/pods_stats.go: Remove Cgroups v1
ecf7f7f 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
pkg/domain/infra/abi/containers.go: Remove Cgroups v1
4984ec0 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
pkg/api/handlers/libpod/containers_stats.go: Remove Cgroups v1
103dafc 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
cmd/podman/system/service_abi_linux.go: Remove Cgroups v1
8adc31c 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
pkg/api/handlers/compat/containers_create.go: Remove Cgroups v1
c10f35c 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
test/e2e: delete CgV1 skips, delete tests skipped on Cgv2
471feaf 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
test/system: delete CgV1 skips and skipped CgV2 tests
c09e4bf 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
docs: Remove Cgroups v1
51e47cf 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
Remove ContainerStats.PerCPU: CGV1 only
797b985 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
test/system: Remove cgroupVersion from podman info tests
6773dca 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 marked this pull request as ready for review November 10, 2025 19:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2025
@lsm5
Copy link
Member Author

lsm5 commented Nov 10, 2025

I would like to remove the HEAD commit from here that does some vendoring to simplify cgroups.AvailableControllers and leave a FIXME note instead. That would move this forward at least.

@containers/podman-maintainers The latest version of this PR has no vendoring and a FIXME has been included. PTAL. Hope we can leave the rest (with vendoring container-libs) for followups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrmac mtrmac mtrmac left review comments

@Luap99 Luap99 Luap99 left review comments

Assignees

No one assigned

Labels

6.0 Breaking changes for Podman 6.0 approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny machine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lsm5 @TomSweeneyRedHat @mtrmac @Luap99